Don't rebroadcast announcements for spent channels #3235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We introduced a mechanism to keep spent channels in the `Router` until the spending transaction has enough confirmations to avoid removing spliced channels from our graph too eagerly. An unwanted side-effect is that while we're waiting for confirmations, we may broadcast channel announcements for these spent channels, which looks like spam to our peers. We now filter out channels that have been spent for which we're waiting for confirmations when sending out gossip.
Another side-effect of the splice change is that we didn't notify front nodes that the channel was spent before it reached enough confirmations so we kept sending channel gossip to our peers. We now immediately notify the front nodes so that they stop sending this channel to our peers.
t-bast
commented
Jan 2, 2026
pm47
approved these changes
Jan 6, 2026
Member
pm47
left a comment
pm47
left a comment
There was a problem hiding this comment.
The seconds commit will cause all splices to have a redundant ChannelLost event. That's probably fine.
Member
Author
Yes exactly, we could avoid it but it would add complexity, while receivers should handle duplicate such events without any issue (which the front nodes correctly do today). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced a mechanism to keep spent channels in the
Routeruntil the spending transaction has enough confirmations to avoid removing spliced channels from our graph too eagerly. An unwanted side-effect is that while we're waiting for confirmations, we may broadcast channel announcements for these spent channels, which looks like spam to our peers.We now filter out channels that have been spent for which we're waiting for confirmations when sending out gossip. In the second commit, we ensure that these announcements are also filtered from front router nodes.
Fixes #3127