Skip to content

Conversation

@tennlee
Copy link
Collaborator

@tennlee tennlee commented Mar 26, 2025

The test coverage is not yet great, but this PR contains a useful change in that the case of the Normalisation class has been corrected. There would be some value in merging this now and raising a new PR for further expanding test coverage, but it is also reasonable to wait while more coverage is added to this PR. It also contains an actual bugfix where part of the code is calling a lower-case "drop" when an upper-case "Drop" is required. Putting up the PR now so that if anyone runs into these issues, they can request an early merge.

@tennlee tennlee requested review from jennan and nikeethr March 26, 2025 11:32
@coveralls
Copy link

coveralls commented Mar 26, 2025

Pull Request Test Coverage Report for Build 14083275211

Details

  • 54 of 55 (98.18%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 54.417%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/data/src/pyearthtools/data/transforms/transform.py 1 2 50.0%
Totals Coverage Status
Change from base Build 14058365217: 0.6%
Covered Lines: 7238
Relevant Lines: 12832

💛 - Coveralls

@tennlee
Copy link
Collaborator Author

tennlee commented Mar 26, 2025

Coverage lifted from around 20% to 44%, but this is a useful increment and I suggest it could be merged here. Remaining coverage will require more complex test data construction and/or more complex mocking to achieve.

@tennlee
Copy link
Collaborator Author

tennlee commented Mar 26, 2025

Merging this to get the bug resolved and improve coverage. Please feel free to raise new issues should there be further work required.

@tennlee tennlee merged commit a870a25 into ACCESS-Community-Hub:develop Mar 26, 2025
5 of 6 checks passed
@jennan
Copy link
Collaborator

jennan commented Mar 26, 2025

Hi @tennlee, would it be ok to run black to make the pre-commit hook happy :-)? I notice it failed on this one.

@tennlee
Copy link
Collaborator Author

tennlee commented Mar 27, 2025

I have just re-run the black and end-of-line formatters, things should be happy again. I will try to help with the isort issues if I can.

@tennlee tennlee deleted the test_default branch April 1, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants