Skip to content

Conversation

@jennan
Copy link
Collaborator

@jennan jennan commented Mar 25, 2025

Fixes #53

  • I have added a dev optional dependency group, that could be used to put other non-test related dependencies.
  • In the CI/CD, I have made it install only the dev dependencies as it is not needed to install all to make it work (and also pip install .[all] will not install the current branch but the default branch develop).

Same as #58 but restarting from more recent baseline and also disabling isort pre-commit hook until we fix the cyclic import issues (numerous ones) when applying isort.

@jennan jennan requested a review from tennlee March 25, 2025 09:30
@jennan jennan mentioned this pull request Mar 25, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14056145630

Details

  • 55 of 55 (100.0%) changed or added relevant lines in 5 files are covered.
  • 66 unchanged lines in 4 files lost coverage.
  • Overall coverage remained the same at 53.796%

Files with Coverage Reduction New Missed Lines %
packages/data/tests/data/transform/test_coordinates.py 1 98.55%
packages/data/tests/data/archive/test_extensions.py 3 81.25%
packages/data/src/pyearthtools/data/save/save_utils.py 24 25.32%
packages/data/src/pyearthtools/data/transforms/coordinates.py 38 83.65%
Totals Coverage Status
Change from base Build 14007760007: 0.0%
Covered Lines: 7135
Relevant Lines: 12787

💛 - Coveralls

@tennlee tennlee merged commit 7f19a06 into ACCESS-Community-Hub:develop Mar 25, 2025
6 checks passed
@jennan jennan deleted the pre-commit-fix branch July 29, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pre-commit to the development dependencies

3 participants