Skip to content

Conversation

@HCookie
Copy link
Collaborator

@HCookie HCookie commented Nov 12, 2025

Address improper type hints on decorators primarily used for convenience on top of data accessors.

Adds

C = TypeVar("C")

in various places

Allows for type checkers and code editors to establish the init args of various classes.

@HCookie HCookie requested a review from tennlee November 12, 2025 23:05
@HCookie HCookie self-assigned this Nov 12, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 19314687946

Details

  • 12 of 13 (92.31%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 61.528%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/data/src/pyearthtools/data/indexes/decorators.py 3 4 75.0%
Totals Coverage Status
Change from base Build 19286124513: 0.002%
Covered Lines: 9636
Relevant Lines: 15246

💛 - Coveralls

@tennlee
Copy link
Collaborator

tennlee commented Nov 12, 2025

Hey, awesome, thank you! Looks great!

@tennlee tennlee merged commit a89e71e into ACCESS-Community-Hub:develop Nov 12, 2025
6 checks passed
ThermoDev pushed a commit to ThermoDev/PyEarthTools that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants