Almost complete test coverage for index modifications #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 19285892796Details
💛 - Coveralls |
Collaborator
|
This looks really good, nothing to add, thanks very much! |
ThermoDev
pushed a commit
to ThermoDev/PyEarthTools
that referenced
this pull request
Nov 12, 2025
…ty-Hub#209) * add TemporalRetrieval test and move TemporalWindow test * cover extra_mods case of TimeIdxModifier * flag DASK_IMPORTED as not covered * test rest of idx_modification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings test coverage for
pipeline/modifications/idx_modification.pyto 97%. One if block is untested because I'm not sure what it's meant to do and I didn't want to add a test for the sake of it.It also: