-
Notifications
You must be signed in to change notification settings - Fork 24
CoordinateExpand and CoordinateFlatten refactoring #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CoordinateExpand and CoordinateFlatten refactoring #183
Conversation
… updated with respect to main repo
…nates.SelectFlatten
Pull Request Test Coverage Report for Build 18579479652Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
This looks great, thanks very much. A note for the future, we are hoping to remove or reduce the use of the BackwardsCompatibility decorator. At the moment we don't have too many dependants on the old patterns, so there's no need to re-create those or persist their use, unless they are actively relied upon in the codebase+notebooks. Changes look good, notebooks seem fine, tests look good. I will re-run the notebook but it's taking me a little time due to the data download proceeding slowly (and for reasons my cache version being unavailable right now). |
This request does the following: