Remove attr.Rename aliases
#182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks. The CI is failing because of an unused import in one of the files. I've run the tests and all is well. I'll merge it and the fix the unused import post-merge. Thanks for the work! |
gemmaellen
pushed a commit
to gemmaellen/PyEarthTools
that referenced
this pull request
Oct 1, 2025
* Remove unnecessary aliases of `Rename` class * 🐛 Fix missed renames of `variable_trim` * Add myself to contributors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removes aliases for
Renameand updated their uses throughout the repo. Also fixes some missed renames after removing deprecated functions.Fixes #181.
attr.Renamevariables_trimtoTrimTesting
Test suite was run locally after finishing commits. No failures or errors were shown.