refactor merge_and_transform_dem_tiles to combine operations#144
Open
mikegraham wants to merge 2 commits into
Open
refactor merge_and_transform_dem_tiles to combine operations#144mikegraham wants to merge 2 commits into
mikegraham wants to merge 2 commits into
Conversation
mikegraham
force-pushed
the
single-warp
branch
4 times, most recently
from
bcaf037 to
fa93abd
Compare
mikegraham
force-pushed
the
single-warp
branch
2 times, most recently
from
0ba5bc0 to
a1f2353
Compare
The old code did two separate reproject calls: one for CRS (4269->4326) and one for resolution. This combines them into a single warp via _build_target_profile, which computes the target profile with both changes applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #143
Previously merge_and_transform_dem_tiles potentially had two operations performed on the DEM data in two separate reproject_arr_to_match_profile calls. This combines the two into one for performance reasons.
Also, only one used the num_threads_reproj before, so this compounds the speedup by doing the single operation with num_threads_reproj.