feat: add getVoicesByGender() and fix gender mappings in Google and ElevenLabs#45
Merged
Merged
Conversation
…nLabs (#44) - Add AbstractTTSClient.getVoicesByGender() reusing existing filterByGender() utility - Fix Google engine: map ssmlGender MALE/FEMALE/NEUTRAL → Male/Female/Unknown (was lowercase) - Fix ElevenLabs bulk voice list: map labels.gender when present; leave undefined otherwise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44
Summary
getVoicesByGender(gender: "Male" | "Female" | "Unknown"): Promise<UnifiedVoice[]>toAbstractTTSClient, reusing the existingfilterByGender()utility fromvoice-utils.tsssmlGenderwas lowercased ("male"/"female") which violated theUnifiedVoice.gendertype — now mapsMALE→Male,FEMALE→Female, everything else→Unknown_mapVoicesToUnifiedwas hardcoded togender: undefined; now mapslabels.genderwhen present ("male"→"Male","female"→"Female"), leavingundefinedwhen absent (field is undocumented and not guaranteed by the API)Test plan
npx jest __tests__/abstract-tts-gender.test.ts— 4 tests covering Female/Male/Unknown/empty resultsnpx jest __tests__/google-gender.test.ts— 5 tests covering MALE/FEMALE/NEUTRAL/UNSPECIFIED/missingnpx jest __tests__/elevenlabs-gender.test.ts— 4 tests covering female/male/absent labels/no labelsnpm run build— clean build, no TypeScript errors