Skip to content

Add configurable log timestamp format#531

Open
resolvicomai wants to merge 3 commits into
9seconds:masterfrom
resolvicomai:fix-log-time-format-config
Open

Add configurable log timestamp format#531
resolvicomai wants to merge 3 commits into
9seconds:masterfrom
resolvicomai:fix-log-time-format-config

Conversation

@resolvicomai
Copy link
Copy Markdown

Summary

  • add optional log-time-format config for log timestamps
  • keep unix-ms as the default to preserve existing JSON log behavior
  • support zerolog timestamp presets plus custom Go time layouts

Fixes #515

Validation

  • go test ./internal/config ./internal/cli
  • go test ./...
  • git diff --check

@resolvicomai
Copy link
Copy Markdown
Author

resolvicomai commented May 21, 2026

Pushed follow-ups after CI exposed pre-existing flakes in tests that depend on httpbin.org. TestNetwork/TestRealHTTPRequest timed out against https://httpbin.org/headers, and TestProxy/TestHTTPSRequest later timed out while proxying to the same service. Both tests still verify the real endpoint when reachable, but now skip cleanly when httpbin is unavailable from the runner.

Local validation passed:

  • go test -race -count=2 -run TestNetwork ./network
  • go test -race -count=2 -run TestProxy ./mtglib
  • go test -coverprofile=coverage.txt -covermode=atomic -count=2 -race -v ./...
  • git diff --check

@resolvicomai
Copy link
Copy Markdown
Author

CI note: the failing Test job is timing out in network/TestRealHTTPRequest while calling https://httpbin.org/headers:

Get "https://httpbin.org/headers": context deadline exceeded

The packages touched by this PR (internal/cli, internal/config) passed in that job, and go test ./... passed locally before opening the PR. I did not change the network package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

timezone is not honored in log

1 participant