Conversation
Since the contents of MSRs is stored in ret anyways, we can make a syscall to close a MSRs' fd, otherwise we are likely to hit the limit of open files per process (i.e. 'ReadMSR - gomsr.MSR context aborted with: too many open files'). Signed-off-by: Michal Gorlas <michal.gorlas@9elements.com>
Signed-off-by: Michal Gorlas <michal.gorlas@9elements.com>
Signed-off-by: Michal Gorlas <michal.gorlas@9elements.com>
walterchris
reviewed
Feb 17, 2026
walterchris
approved these changes
Feb 17, 2026
micgor32
added a commit
that referenced
this pull request
Feb 17, 2026
ReadMSR returns uint64 instead of an array of uint64 since #16. Previously, we read first element of the array (corresponding to core 0), now since ReadMSR only reads of MSR of core 0, we can just work with the value it returns. Signed-off-by: Michal Gorlas <michal.gorlas@9elements.com>
micgor32
added a commit
that referenced
this pull request
Feb 17, 2026
ReadMSR returns uint64 instead of an array of uint64 since #16. Previously, we read first element of the array (corresponding to core 0), now since ReadMSR only reads of MSR of core 0, we can just work with the value it returns. Signed-off-by: Michal Gorlas <michal.gorlas@9elements.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the contents of MSRs is stored in ret anyways, we can make a syscall to close a MSRs' fd, otherwise we are likely to hit the limit of open files per process (i.e. 'ReadMSR - gomsr.MSR context aborted with: too many open
files').