Fix local resource previews for paths containing hashes#8586
Open
bodhibuurstede-sys wants to merge 3 commits into
Open
Fix local resource previews for paths containing hashes#8586bodhibuurstede-sys wants to merge 3 commits into
bodhibuurstede-sys wants to merge 3 commits into
Conversation
Author
|
Hi @4ian, the Semaphore PR check is green now after the libGD.js fallback update. This should be ready for review when you have a chance; happy to adjust anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file://URLs so#characters stay part of the pathname instead of becoming URL fragments.ResourcesLoadercoverage for aWeekend Jam #1-style path and cache-busting query strings.libGD.jsdownloader try matchingmaster/commit/<hash>builds beforemaster/latest, so detached PR CI does not pick an incompatible generated file.Fixes #4015.
Testing
#and cache-busting query parameters.Fast tests (not building GDevelop.js - can have false negatives): passed on the latest commit.