Skip to content

Fix rotated text position when content changes#8584

Open
mizoz wants to merge 1 commit into4ian:masterfrom
mizoz:fix/text-object-rotated-position-975
Open

Fix rotated text position when content changes#8584
mizoz wants to merge 1 commit into4ian:masterfrom
mizoz:fix/text-object-rotated-position-975

Conversation

@mizoz
Copy link
Copy Markdown

@mizoz mizoz commented May 10, 2026

Fixes #975.

Rotated text objects were using the current rendered text bounds as their rotation center. When the text content changed size, the center moved, so the rendered object appeared to drift even though its X/Y stayed the same.

This keeps the rotation center stable while rotated text changes content, and applies the same positioning logic to Text, BBText, and BitmapText objects.

Verification:

  • npm run build
  • npm run check-types
  • npx karma start --browsers ChromeHeadlessNoSandbox --single-run --client.mocha.grep="keeps the same rotated origin"
  • npx karma start --browsers ChromeHeadlessNoSandbox --single-run --reporters dots

@mizoz mizoz requested a review from 4ian as a code owner May 10, 2026 21:51
@mizoz
Copy link
Copy Markdown
Author

mizoz commented May 10, 2026

I checked the failed Semaphore job. The GDJS typing/tests/format jobs passed there; the red jobs are newIDE typing/tests failing while parsing the downloaded newIDE/app/public/libGD.js artifact with TS1128 / SyntaxError: Unexpected token ')'. Travis passed the full PR build, including newIDE tests and Flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[$5 bounty] Text object at wrong position (and moves!)

1 participant