Fix rotated text position when content changes#8584
Open
mizoz wants to merge 1 commit into4ian:masterfrom
Open
Fix rotated text position when content changes#8584mizoz wants to merge 1 commit into4ian:masterfrom
mizoz wants to merge 1 commit into4ian:masterfrom
Conversation
Author
|
I checked the failed Semaphore job. The GDJS typing/tests/format jobs passed there; the red jobs are newIDE typing/tests failing while parsing the downloaded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #975.
Rotated text objects were using the current rendered text bounds as their rotation center. When the text content changed size, the center moved, so the rendered object appeared to drift even though its X/Y stayed the same.
This keeps the rotation center stable while rotated text changes content, and applies the same positioning logic to Text, BBText, and BitmapText objects.
Verification: