Skip to content

Instance list panel visual update#8573

Open
LuniMoon wants to merge 9 commits intomasterfrom
Instance_panel-z_order
Open

Instance list panel visual update#8573
LuniMoon wants to merge 9 commits intomasterfrom
Instance_panel-z_order

Conversation

@LuniMoon
Copy link
Copy Markdown
Collaborator

@LuniMoon LuniMoon commented May 7, 2026

  • Display Z order (from foreground to background) by default to match how visual tools work (beginners expect front-most object at top of list, matching Figma/Illustrator/Photoshop mental model).
  • Match the rest of the tokens to the updated brand design.

Display Z order (from foreground to background) by default to match how visual tools work (tool learnability).
@LuniMoon LuniMoon self-assigned this May 7, 2026
@LuniMoon LuniMoon requested a review from 4ian as a code owner May 7, 2026 08:28
@LuniMoon LuniMoon marked this pull request as draft May 7, 2026 08:28
LuniMoon added 7 commits May 7, 2026 12:38
Reorder the columns in the Instances List panel so the sequence is:
Object name, X, Y, Z, Angle, Layer, Lock.

The lock icon column was previously the second column; it is now at
the right to follow the UI pattern in other panels.

Also shortened the Z Order column header label to "Z".
Replace the "Angle" and "Layer" text column headers in the Instances List
with SVG icons (RotateZ and Layers) to save horizontal space and match
the icon-first visual language used in the editor.

- Use titleAccess for screen reader accessibility ("Rotation (Z)" / "Layer")
- Size icons with inline style to work around react-virtualized rendering context, where MUI's sx prop and fontSize have no effect
Add a custom headerRenderer to sortable columns in the Instances List table.
The active sort column label now uses the primary text color
(--theme-text-default-color) while inactive headers stay muted
(--table-text-color-header).

A directional arrow icon (↑/↓) is shown next to the active column label to indicate sort direction. Chevrons were replaced (they are used for "open and close" while this use requires "direction").

New icon components added:
- UI/CustomSvgIcons/SortArrowUp.js
- UI/CustomSvgIcons/SortArrowDown.js
Reworks the visual appearance of the Instances List panel to remove inconsistent background colors and create a cohesive look with the rest of the panels:

- Row backgrounds (odd and even) now use the primary window background color, removing the alternating stripe pattern
- The column header row ("Object name, X, Y, Z…") uses the toolbar surface color, visually grouping it with the search bar area
- Adds a mosaic-editor-{panelName} class to mosaic windows, enabling per-panel CSS targeting
- CSS rule for the Instances List panel body, keeping other panels unaffected
Replacing old blue with branded purple to match the rest of the panels.
Matching the text display (Light and Dark) to proper color tokens.
@LuniMoon LuniMoon changed the title Z order by default Instance list panel visual update May 7, 2026
- Use --table-text-color-header for inactive sort column headers instead of --theme-text-secondary-color, which is too dark in light theme
- Remove custom cellRenderer on Object name column that was overriding the selected-row text color and breaking row highlight consistency
- Remove unused GDevelopThemeContext import and Consumer wrapper
- Fix indentation left misaligned after Consumer removal
@LuniMoon LuniMoon marked this pull request as ready for review May 7, 2026 15:53
@LuniMoon
Copy link
Copy Markdown
Collaborator Author

LuniMoon commented May 7, 2026

Updating the UI debt of the old Instance List
Screenshot 2026-05-07 at 17 54 46

To the updated version following new UI patterns.
Screenshot 2026-05-07 at 17 55 52

Note: I couldn't manage to crack why the background color of the panel is a murky grey (#F3F3F6) instead of the proper shade of grey00 (#F5F5F7) like the rest of the panels in Light mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant