-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Folders to organize scenes, external events, and external layouts #7777 and #8165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
newIDE/app/src/ProjectManager/ExternalLayoutFolderTreeViewItemContent.js
Show resolved
Hide resolved
4ian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
First, thanks for opening this, appreciate your work on this.
To have this considered for a potential inclusion in GDevelop, we need some attention to quality and details in the code and in the app, here is a quick list from what I've seen just looking quickly:
- You've added some comments in German. All the code of GDevelop is commented in English. For each comment you added, consider if:
- 1 (better): remove it if it does not add any information to the exist code.
- 2 (otherwise): translate it in english
- On the contrary, you've sometimes removed existing comments. Can you put them back? Any comment in the existing code must be preserved, especially those explaining hacks or things to know. For example, a setTimeout is something that we should in theory never use. If there is one, you must absolutely keep the comments.
- I've tried it and it works for scenes (great! :)) but external layouts and external events don't have 1) the menu item to add folders and 2) they have an extra triple dot menu that is useful.
Take a careful look at all my comments, ensure the external layout/events and scenes folders can be used from the UI and ensure the code is as clean as possible (without losing existing information) and this would be then a great addition :) Looking forward to your changes! Thanks again! :)
|
Hi @4ian , thank you for your feedback! We have fixed the comments you have written. Looking forward to your feedback! |


Our student group has made the folders to organize scenes, so you can make folders, put the scenes in it and help to organize the game production better.