Skip to content

Conversation

@anasiez
Copy link

@anasiez anasiez commented Jan 23, 2026

Our student group has made the folders to organize scenes, so you can make folders, put the scenes in it and help to organize the game production better.

@anasiez anasiez requested a review from 4ian as a code owner January 23, 2026 16:47
Copy link
Owner

@4ian 4ian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

First, thanks for opening this, appreciate your work on this.

To have this considered for a potential inclusion in GDevelop, we need some attention to quality and details in the code and in the app, here is a quick list from what I've seen just looking quickly:

  • You've added some comments in German. All the code of GDevelop is commented in English. For each comment you added, consider if:
    • 1 (better): remove it if it does not add any information to the exist code.
    • 2 (otherwise): translate it in english
  • On the contrary, you've sometimes removed existing comments. Can you put them back? Any comment in the existing code must be preserved, especially those explaining hacks or things to know. For example, a setTimeout is something that we should in theory never use. If there is one, you must absolutely keep the comments.
  • I've tried it and it works for scenes (great! :)) but external layouts and external events don't have 1) the menu item to add folders and 2) they have an extra triple dot menu that is useful.
    • Can you fix this and confirm you've tried/tested this manually?
      See, nothing here:
      Image
      While it works here:
      Image

Take a careful look at all my comments, ensure the external layout/events and scenes folders can be used from the UI and ensure the code is as clean as possible (without losing existing information) and this would be then a great addition :) Looking forward to your changes! Thanks again! :)

@anasiez
Copy link
Author

anasiez commented Jan 26, 2026

Hi @4ian ,

thank you for your feedback! We have fixed the comments you have written.
We confirm that it looks the same like you have posted on your screenshots. We didn't make the whole feature and didn't touch the folders for events and layouts, we have made it only for the scenes. :) I hope it is okay that we did it just for scenes. We will appreciate if it will be merged, it was making fun to contribute to your project!

Looking forward to your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants