fix: UTF-8 encoding and DML support for app.py#4
Open
Cerco01 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
While completing the SQL analysis exercise I ran into two bugs in
app.pythat affect all students. I investigated the root causeof each one and fixed them after finishing the exercise.
Changes in
src/app.pyFIX 1 — UTF-8 encoding
The original
open()call did not specify an encoding, so Python used the OS default (cp1252 on Windows). This caused the error:charmap codec can't decode byte 0x8fbecause
queries.sqlcontains UTF-8 characters (accents, emojis).Fix: added
encoding='utf-8'explicitly to theopen()call.FIX 2 — DML support (INSERT, UPDATE, DELETE)
pd.read_sql()only handles SELECT statements, as it expects rows in return. For INSERT/UPDATE/DELETE it raised:This result object does not return rows. It has been closed automatically.Fix: detect the statement type and route DML operations to
engine.begin()withsqlalchemy.text(), which handles transactionscorrectly. SELECT statements continue using
pd.read_sql().Note
Both fixes are documented with inline comments in
app.pyexplaining the original issue and the solution applied.