Skip to content

Do not deduplicate single line polygon #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Czaki merged 3 commits into from
Feb 14, 2025
Merged

Do not deduplicate single line polygon #65

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c1fce0
do not deduplicate single line polygon
Czaki Feb 13, 2025
5f3e086
render edges of short polygon
Czaki Feb 14, 2025
5a87e19
update docstring
Czaki Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/PartSegCore_compiled_backend/triangulation/triangulate.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1320,13 +1320,17 @@ struct GraphNode {
* resulting sub-polygon contains unique edges. This operation can help to
* resolve ambiguities in complex or self-intersecting polygons.
*
* Note: Polygons with exactly 2 points are treated as single line segments and
* are not processed for edge deduplication between their first and last points.
*
* @param polygon The input polygon represented as a list of edges.
*
* @return A vector of sub-polygons, where each sub-polygon is free of repeated
* edges.
*/
inline std::vector<std::vector<point::Point>> split_polygon_on_repeated_edges(
const std::vector<point::Point> &polygon) {
if (polygon.size() < 3) return {polygon};
auto edges_dedup = calc_dedup_edges({polygon});
std::vector<std::vector<point::Point>> result;
point::Segment segment;
Expand Down
Loading