Implementing the m3y scanner #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Maybe we can merge this and @Schnuartz will check whether the supported commands are properly working from a functional point of view before trying to implement them in specter-diy (At least illumination does not work yet in Specter-DIY). |
Author
|
Reminder @3rdIteration ! I'll try to spend some time investigating cryptoadvance/specter-diy#314 and will do that based on this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the m3y module does not support as many query commands as the gm65 model.
I haven't verified it myself but the vibe-session was quite consistent about that behaviour.
I've added tests which reflects that.
However there is one command for the sw-version which seem to be supported but is not working as documented.