Skip to content

Conversation

@primetheus
Copy link
Collaborator

@primetheus primetheus commented Aug 22, 2023

This replaces github3.py with ghapi for easier long-term support

fixes #83
fixes #115

except GitHubAppValidationError as e:
LOG.error(e)
error_response = make_response(
jsonify(status="ERROR", description=str(e)), 400

Check warning

Code scanning / CodeQL

Information exposure through an exception

[Stack trace information](1) flows to this location and may be exposed to an external user.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in our context this is fine and not an information leak

@primetheus primetheus added the enhancement New feature or request label Aug 22, 2023
@Chocrates
Copy link
Contributor

Is github3.py no longer maintained?

@primetheus
Copy link
Collaborator Author

Is github3.py no longer maintained?

@Chocrates it's still maintained, but features lag behind GitHub's capabilities. Since ghapi is automatically generated from GitHub's API spec, it gives us better compatibility going forward with less to maintain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecated Teams API Endpoints Dependency

3 participants