Skip to content

Conversation

@jpauwels
Copy link

Title says it all :-)

@lmtanco
Copy link
Member

lmtanco commented Feb 2, 2023

Hi @jpauwels !

Many thanks for this! It is super-useful for us to have the examples updated with Xcode project files, something we have been wanting to do, but never found time for it.

Regarding your PR, unfortunately we cannot merge it because just yesterday (a few hours after you did your PR) we updated the examples to use the latest 3dti_AudioToolkit master, which includes new files and dependencies that are now missing in your Xcode project file. This was just a coincidence, we had planned this task for this sprint and this crashed with your PR. Sorry about this!

If you had the time and were so kind to update your fork accordingly, then create a new PR, we would then be able to merge it. Also, please make sure you do not force-push any commits - we are not sure how this may affect the main repo's history.

Best,
Luis

@lmtanco lmtanco closed this Feb 2, 2023
@lmtanco lmtanco reopened this Feb 2, 2023
@lmtanco
Copy link
Member

lmtanco commented Feb 2, 2023

sorry, didn't mean to close it. We can close it when/if you create a new one. In the meantime, I think it is useful for others to find it here and have a link to your fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants