Skip to content

Conversation

@343dev
Copy link
Owner

@343dev 343dev commented Dec 23, 2025

TL;DR

Fixed CLI test execution by properly quoting the CLI path.

What changed?

Added double quotes around the CLI path in the runCliWithParameters function to ensure proper handling of paths with spaces.

How to test?

  1. Run the CLI tests with the codebase in a path containing spaces
  2. Verify that the tests execute successfully without path-related errors

Why make this change?

Paths often contain spaces and special characters that can cause issues when not properly quoted in command execution. This fix ensures that the CLI tests run reliably across all operating systems, by properly escaping the path to the CLI executable.

Copy link
Owner Author

343dev commented Dec 23, 2025

@343dev 343dev marked this pull request as ready for review December 23, 2025 03:32
@343dev 343dev self-assigned this Dec 23, 2025
Base automatically changed from 12-23-configure_trusted_publishing_for_npm_package to main December 23, 2025 05:16
Copy link
Owner Author

@343dev 343dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@343dev 343dev force-pushed the Fix_CLI_path_handling_in_tests branch from 0df5f60 to 43f6c64 Compare December 23, 2025 05:58
@343dev 343dev merged commit d84bd22 into main Dec 23, 2025
6 of 8 checks passed
@343dev 343dev deleted the Fix_CLI_path_handling_in_tests branch December 23, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant