Skip to content

Refactor output.rs into output/ submodule#129

Merged
2witstudios merged 3 commits intomainfrom
pu/refactor-output
Mar 10, 2026
Merged

Refactor output.rs into output/ submodule#129
2witstudios merged 3 commits intomainfrom
pu/refactor-output

Conversation

@2witstudios
Copy link
Owner

@2witstudios 2witstudios commented Mar 10, 2026

Summary

  • Split the 1,282-line monolithic output.rs into a focused output/ submodule with 6 files: formatters.rs, agents.rs, definitions.rs, execution.rs, system.rs, and tests.rs
  • Pure refactoring — no behavior changes, same public API (check_response + print_response)
  • After rebase onto main, added handler for new AssignTriggerResult response variant (from PR feat: Make triggers opt-in and fix inject submission #131)
  • All 93 existing tests pass unchanged, zero compiler warnings, clippy clean

Test plan

  • cargo build -p pu-cli — no warnings or errors
  • cargo clippy -p pu-cli --all-targets — no warnings
  • cargo test -p pu-cli — 93 tests pass
  • Pre-commit hooks pass (rustfmt + hygiene)

🤖 Generated with Claude Code

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai
Copy link

coderabbitai bot commented Mar 10, 2026

Warning

Rate limit exceeded

@2witstudios has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 20 minutes and 38 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 124ebbd8-b60f-400c-83e7-01414ae189d7

📥 Commits

Reviewing files that changed from the base of the PR and between 8d8ff39 and 9e030b8.

📒 Files selected for processing (8)
  • crates/pu-cli/src/output.rs
  • crates/pu-cli/src/output/agents.rs
  • crates/pu-cli/src/output/definitions.rs
  • crates/pu-cli/src/output/execution.rs
  • crates/pu-cli/src/output/formatters.rs
  • crates/pu-cli/src/output/mod.rs
  • crates/pu-cli/src/output/system.rs
  • crates/pu-cli/src/output/tests.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pu/refactor-output

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

2witstudios and others added 3 commits March 9, 2026 22:22
Break the 1,282-line monolithic output.rs into focused submodules:
formatters, agents, definitions, execution, system, and tests.
No behavior changes — all 93 tests pass unchanged.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The print_agent_def_detail and print_schedule_detail functions mirror
the Response enum variant fields directly. Adding the allow attribute
satisfies CI clippy (-D warnings) without restructuring the API.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Handle the new Response::AssignTriggerResult variant added in PR #131,
delegating to agents::print_assign_trigger_result.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@2witstudios 2witstudios merged commit 1f7ddb6 into main Mar 10, 2026
5 checks passed
@2witstudios 2witstudios deleted the pu/refactor-output branch March 10, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant