fix: storage write failures and orphaned blob cleanup#40
Open
fix: storage write failures and orphaned blob cleanup#40
Conversation
…, closes #7) StorageService::store() now throws RuntimeException when mkdir() or file_put_contents() fails, preventing silent data loss. BundleRoutingService::routeBundle() wraps DB insert + storage-usage update in a transaction and deletes the blob on failure. CreateInviteHandler does the same for invite blob writes.
Dockerfile (multi-stage), docker-compose.yml, and entrypoint script. `docker compose up` starts the relay at localhost:8080 with auto-init. `docker compose run test` runs PHPUnit with dev dependencies.
Remove the base_url setting from config/settings.php and derive it from the PSR-7 request URI in all three invite handlers. This makes invite URLs correct in any environment without configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mkdir()andfile_put_contents()return values, throwingRuntimeExceptionon failure instead of silently returning a phantom path (closes C3: Storage write failures are silently ignored #6)docker compose upstarts the relay at localhost:8080,docker compose run testruns PHPUnitTest plan
docker compose run test)docker compose up)storage/bundles/read-only and confirming aRuntimeExceptionis thrown on upload.swarmfile is left behind