Skip to content

Conversation

@Georges760
Copy link
Contributor

to be tested

- Install Start SDK from source since npm package not available
- Fix Docker build context paths
- Update Makefile to use correct Docker build command
- Add proper icon creation fallback
- Fix file paths for package creation
- Update Docker image name to match build
- Fix build command in manifest
- Make scripts executable
- Update from Node.js 18.x to 20.x to resolve TypeScript execution issues
- Node.js 18.x was failing during 'npm run buildOutput' with ERR_UNKNOWN_FILE_EXTENSION
- Node.js 20.x has better ES modules and TypeScript support
- The buildOutput step fails due to TypeScript ES module compatibility
- This step is only needed for SDK development, not for usage
- Skip the problematic step to allow Start9 package creation to proceed
- Add npm global bin directory to PATH after installation
- npm global installs may not be in default PATH in CI environment
- Export PATH before calling start-sdk --version
@Georges760 Georges760 marked this pull request as draft November 6, 2025 16:15
- Use full path to start-sdk for immediate execution
- Add npm bin directory to GITHUB_PATH for subsequent steps
- npm config get prefix provides correct global installation path
- Check what files were actually created by npm global install
- Use find to locate start-sdk executable
- Try npx as alternative to run start-sdk
- Debug installation process to understand the issue
- Replace 'make dev-build' with 'just build-release'
- Hydra-Pool uses just for task management, not make
- Follow commands from AGENTS.md development guide
- Add just installation step after Rust toolchain
- just is required for build commands but not installed by default
- Use official just installation script
@LocoSlug
Copy link

LocoSlug commented Nov 6, 2025

If appropriate, I would like to suggest adding the config option pplns_ttl_days. Thanks in advance.

@pool2win
Copy link
Collaborator

Hi @Georges760 thanks for taking the time to work on the start9 package. It is much needed.

Caveat: I have never built a start9 package, so it is really nice you are helping us out here. Also, sorry for not seeing this earlier. I wasn't monitoring telegram.

Couple of big overall points:

  1. We have docker files in the docker folder. We actually have a github action that builds them an include the docker images in the releases. Is there no to reuse those docker images? That was kind of my hope that we can take those images from ghcr.io and use them for start9/umbrel etc.
  2. I am not a nix user, can we avoid depending on nix? It will just take me a LOT of effort to try and run things locally and testing them before we can merge things.

Regarding the dockerfiles, if the issue is that we need entrypoints in a certain way, can we build images for s9 are simple wrapper around the release images? I want to avoid having to maintain multiple docker files for the same service.

@Georges760
Copy link
Contributor Author

Nix is not a hard requirement, the flake i added is just for nix user to have a build setup in no time. Any other user (like you) can continue building on their system as you do currently. (I am on NixOS so I hd to do this nix flake in order to build hydrapool, so I commited them to to let other nix users profit from them too).

As of start9, I never did a pkg neither. It is my first one, and i largely abused vibe coding instead of reading properly the documentation for it. I beleive it is based on the 3 docker images you made. My current undersatnding is that the real start9 SDK should be installed on the build system and then my code should allow to build the packages. It is currently using a stub for this SDK.
I guess we need someone who actually knows about start9 packages and tell us if my PR is usefull or not.

@pool2win
Copy link
Collaborator

pool2win commented Nov 20, 2025

Yeah, I agree. At least maybe have a start9 device around so we can properly test everything works too.

If you do want to share nix stuff, it might be an idea to have a separate PR for nix only. Or, I think @econoalchemist won't mind if we did a brand new repo called hydrapool-nix where we have the nix setup of hydrapool.

@Georges760
Copy link
Contributor Author

i can make a separate PR for Nix user support to build HydraPool.

There is no need a of a new repo, the nix flake are highly dependant on the project to be build, so usually they live in the same repo. It is like the docker build, they are not mandatory to build the pool project itself. But user wanting to use them can.

@pool2win
Copy link
Collaborator

pool2win commented Nov 20, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants