Remove bitcoin-tx executable

.github/ci-windows.py

@@ -168,7 +168,6 @@ def run_tests(ci_type):
             "BITCOIND": "bitcoind.exe",
             "BITCOINCLI": "bitcoin-cli.exe",
             "BITCOIN_BENCH": "bench_bitcoin.exe",
-            "BITCOINTX": "bitcoin-tx.exe",
             "BITCOINUTIL": "bitcoin-util.exe",
             "BITCOINCHAINSTATE": "bitcoin-chainstate.exe",
         }

CMakeLists.txt

@@ -108,7 +108,6 @@ option(BUILD_DAEMON "Build bitcoind executable." ON)
 option(BUILD_CLI "Build bitcoin-cli executable." ON)
 
 option(BUILD_TESTS "Build test_bitcoin and other unit test executables." ON)
-option(BUILD_TX "Build bitcoin-tx executable." ${BUILD_TESTS})
 
 option(BUILD_UTIL_CHAINSTATE "Build experimental bitcoin-chainstate executable." OFF)
 option(BUILD_KERNEL_LIB "Build experimental bitcoinkernel library." ${BUILD_UTIL_CHAINSTATE})
@@ -183,7 +182,6 @@ if(BUILD_FOR_FUZZING)
   set(BUILD_BITCOIN_BIN OFF)
   set(BUILD_DAEMON OFF)
   set(BUILD_CLI OFF)
-  set(BUILD_TX OFF)
   set(BUILD_UTIL_CHAINSTATE OFF)
   set(BUILD_KERNEL_LIB OFF)
   set(BUILD_KERNEL_TEST OFF)
@@ -590,7 +588,6 @@ message("  bitcoin ............................. ${BUILD_BITCOIN_BIN}")
 message("  bitcoind ............................ ${BUILD_DAEMON}")
 message("  bitcoin-node (multiprocess) ......... ${BUILD_DAEMON}")
 message("  bitcoin-cli ......................... ${BUILD_CLI}")
-message("  bitcoin-tx .......................... ${BUILD_TX}")
 message("  bitcoin-chainstate (experimental) ... ${BUILD_UTIL_CHAINSTATE}")
 message("  libbitcoinkernel (experimental) ..... ${BUILD_KERNEL_LIB}")
 message("  kernel-test (experimental) .......... ${BUILD_KERNEL_TEST}")

cmake/module/Maintenance.cmake

@@ -19,7 +19,7 @@ function(setup_split_debug_script)
 endfunction()
 
 function(add_windows_deploy_target)
-  if(MINGW AND TARGET bitcoin AND TARGET bitcoind AND TARGET bitcoin-cli AND TARGET bitcoin-tx AND TARGET test_bitcoin)
+  if(MINGW AND TARGET bitcoin AND TARGET bitcoind AND TARGET bitcoin-cli AND TARGET test_bitcoin)
     find_program(MAKENSIS_EXECUTABLE makensis)
     if(NOT MAKENSIS_EXECUTABLE)
       add_custom_target(deploy
@@ -38,7 +38,6 @@ function(add_windows_deploy_target)
       COMMAND ${CMAKE_STRIP} $<TARGET_FILE:bitcoin> -o ${PROJECT_BINARY_DIR}/release/$<TARGET_FILE_NAME:bitcoin>
       COMMAND ${CMAKE_STRIP} $<TARGET_FILE:bitcoind> -o ${PROJECT_BINARY_DIR}/release/$<TARGET_FILE_NAME:bitcoind>
       COMMAND ${CMAKE_STRIP} $<TARGET_FILE:bitcoin-cli> -o ${PROJECT_BINARY_DIR}/release/$<TARGET_FILE_NAME:bitcoin-cli>
-      COMMAND ${CMAKE_STRIP} $<TARGET_FILE:bitcoin-tx> -o ${PROJECT_BINARY_DIR}/release/$<TARGET_FILE_NAME:bitcoin-tx>
       COMMAND ${CMAKE_STRIP} $<TARGET_FILE:test_bitcoin> -o ${PROJECT_BINARY_DIR}/release/$<TARGET_FILE_NAME:test_bitcoin>
       COMMAND ${MAKENSIS_EXECUTABLE} -V2 ${PROJECT_BINARY_DIR}/bitcoin-win64-setup.nsi
       VERBATIM

contrib/completions/bash/bitcoin.bash

@@ -57,10 +57,6 @@ _bitcoin() {
             _bitcoin_wrap bitcoin-cli "$offset"
             return 0
             ;;
-        tx)
-            _bitcoin_wrap bitcoin-tx "$offset"
-            return 0
-            ;;
     esac
 
     case "$cur" in

contrib/devtools/gen-manpages.py

@@ -13,7 +13,6 @@
 'bin/bitcoin',
 'bin/bitcoind',
 'bin/bitcoin-cli',
-'bin/bitcoin-tx',
 ]
 
 parser = argparse.ArgumentParser(

doc/files.md

@@ -90,7 +90,6 @@ This table describes the files installed by Bitcoin Core across different platfo
 | bitcoin.conf                                               | [Generated](../contrib/devtools/gen-bitcoin-conf.sh) configuration file     |
 | bin/bitcoin                                                | Command-line tool for interacting with Bitcoin. Calls other binaries below. |
 | bin/bitcoin-cli                                            | Tool for making node RPC calls.                                             |
-| bin/bitcoin-tx                                             | Tool for creating and modifying transactions                                |
 | bin/bitcoind                                               | Bitcoin node daemon                                                         |
 | *lib/libbitcoinkernel.so*                                  | Shared library containing core consensus and validation code                |
 | *lib/pkgconfig/libbitcoinkernel.pc*                        | Pkg-config metadata for linking to `libbitcoinkernel`                       |

src/CMakeLists.txt

@@ -302,21 +302,6 @@ if(BUILD_CLI)
 endif()
 
 
-if(BUILD_TX)
-  add_executable(bitcoin-tx bitcoin-tx.cpp)
-  add_windows_resources(bitcoin-tx bitcoin-tx-res.rc)
-  add_windows_application_manifest(bitcoin-tx)
-  target_link_libraries(bitcoin-tx
-    core_interface
-    bitcoin_common
-    bitcoin_util
-    univalue
-  )
-  install_binary_component(bitcoin-tx HAS_MANPAGE)
-endif()
-
-
-
 if(BUILD_KERNEL_LIB)
   add_subdirectory(kernel)
   if (BUILD_KERNEL_TEST)