Skip to content

fix: accept stringified ambient cycle counts#116

Open
zerone0x wants to merge 1 commit into1jehuang:masterfrom
zerone0x:fix/106-ambient-string-counts
Open

fix: accept stringified ambient cycle counts#116
zerone0x wants to merge 1 commit into1jehuang:masterfrom
zerone0x:fix/106-ambient-string-counts

Conversation

@zerone0x
Copy link
Copy Markdown

@zerone0x zerone0x commented May 3, 2026

Summary

  • allow the ambient cycle tool to deserialize numeric counters from either JSON numbers or integer strings
  • apply the same lenient handling to next_schedule.wake_in_minutes
  • add regression coverage for stringified counts

Fixes #106

Test Plan

  • cargo fmt --all
  • cargo test -q test_end_cycle_input (blocked locally: missing pkg-config/OpenSSL development metadata; sudo requires a password on this host)

View in Codesmith
Need help on this PR? Tag @codesmith with what you need.

  • Let Codesmith autofix CI failures and bot reviews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ambient: end_ambient_cycle fails with 'invalid type: string, expected u32' - serde type coercion bug

1 participant