-
Notifications
You must be signed in to change notification settings - Fork 0
Fix incorrect URL encoding for square brackets in Absolute.encodePath() #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/main/java/com/github/_1c_syntax/utils/CaseInsensitivePattern.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| /* | ||
| * This file is a part of 1c-syntax utils. | ||
| * | ||
| * Copyright (c) 2018-2025 | ||
| * Copyright (c) 2018-2026 | ||
| * Alexey Sosnoviy <labotamy@gmail.com>, Nikita Fedkin <nixel2007@gmail.com> and contributors | ||
| * | ||
| * SPDX-License-Identifier: LGPL-3.0-or-later | ||
|
|
@@ -250,4 +250,90 @@ void testUriObjectWithPercent() { | |
| assertThat(uri.getPath()).contains("% "); | ||
| assertThat(uri.getPath()).endsWith(".bsl"); | ||
| } | ||
|
|
||
| @Test | ||
| void testUriFromUriWithBrackets() { | ||
| // given | ||
| var file = new File("/git/[folder]/test[1].bsl"); | ||
| var uriFromFile = file.toURI(); | ||
|
|
||
| // when | ||
| var uri = Absolute.uri(uriFromFile); | ||
|
|
||
| // then | ||
| assertThat(uri).hasScheme("file"); | ||
| assertThat(uri.toString()).doesNotContain("["); | ||
| assertThat(uri.toString()).doesNotContain("]"); | ||
| assertThat(uri.getPath()).contains("[folder]"); | ||
| assertThat(uri.getPath()).endsWith("test[1].bsl"); | ||
| } | ||
|
|
||
| @Test | ||
| void testUriFromFileWithBrackets() { | ||
| // given | ||
| var file = new File("/git/[folder]/test[1].bsl"); | ||
|
|
||
| // when | ||
| var uri = Absolute.uri(file); | ||
|
|
||
| // then | ||
| assertThat(uri).hasScheme("file"); | ||
| assertThat(uri.toString()).doesNotContain("["); | ||
| assertThat(uri.toString()).doesNotContain("]"); | ||
| assertThat(uri.getPath()).contains("[folder]"); | ||
| assertThat(uri.getPath()).endsWith("test[1].bsl"); | ||
|
Comment on lines
+281
to
+284
|
||
| } | ||
|
|
||
| @Test | ||
| void testPathFromStringWithBrackets() { | ||
| // given | ||
| var pathString = "/git/[folder]/test[1].bsl"; | ||
|
|
||
| // when | ||
| var path = Absolute.path(pathString); | ||
|
|
||
| // then | ||
| assertThat(path.toString()).contains("[folder]"); | ||
| assertThat(path.toString()).endsWith("test[1].bsl"); | ||
| } | ||
|
|
||
| @Test | ||
| void testPathFromUriWithBrackets() { | ||
| // given | ||
| var file = new File("/git/[folder]/test[1].bsl"); | ||
| var uriFromFile = file.toURI(); | ||
|
|
||
| // when | ||
| var path = Absolute.path(uriFromFile); | ||
|
|
||
| // then | ||
| assertThat(path.toString()).contains("[folder]"); | ||
| assertThat(path.toString()).endsWith("test[1].bsl"); | ||
| } | ||
|
|
||
| @Test | ||
| void testPathFromPathWithBrackets() { | ||
| // given | ||
| var pathFromString = java.nio.file.Path.of("/git/[folder]/test[1].bsl"); | ||
|
|
||
| // when | ||
| var path = Absolute.path(pathFromString); | ||
|
|
||
| // then | ||
| assertThat(path.toString()).contains("[folder]"); | ||
| assertThat(path.toString()).endsWith("test[1].bsl"); | ||
| } | ||
|
|
||
| @Test | ||
| void testPathFromFileWithBrackets() { | ||
| // given | ||
| var file = new File("/git/[folder]/test[1].bsl"); | ||
|
|
||
| // when | ||
| var path = Absolute.path(file); | ||
|
|
||
| // then | ||
| assertThat(path.toString()).contains("[folder]"); | ||
| assertThat(path.toString()).endsWith("test[1].bsl"); | ||
| } | ||
| } | ||
2 changes: 1 addition & 1 deletion
2
src/test/java/com/github/_1c_syntax/utils/StringInternerTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These assertions verify that brackets are absent from the serialized URI, but they don’t explicitly validate that the encoding is the expected
%5B/%5D(and not another percent sequence). Consider asserting againsturi.getRawPath()(oruri.toString()) that it contains%5Band%5D(optionally also asserting it does not contain%91/%93) to make the regression test directly cover the bug being fixed.