Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
openstackCLI, as well as Rust-basedoscCLI.OS_env vars.openrc.shfile on current pathclouds.yamlfile, in any usual location. It also parses thesecure.yamlfile, if available.OS_AUTH_TYPEis set automatically at provision time:v3applicationcredential: whenOS_APPLICATION_CREDENTIAL_IDis present.OS_USERNAMEandOS_PASSWORDare stripped to avoid conflicting parameters.password: otherwise.Type of change
Test Plan
make openstack/validate: all checks passmake test: openstack tests pass (17 scenarios covering provisioner, importer, and NeedsAuth)make openstack/build: builds and installs locallyop plugin init openstack: end-to-end verification (requires 1Password CLI)openstack token issuefor validation