Pass args to plugin shell functions#545
Merged
mrjones2014 merged 3 commits into1Password:mainfrom Aug 27, 2025
Merged
Conversation
BJSummerfield
force-pushed
the
bjs/fish-plugins
branch
from
04b86a2 to
821d07e
Compare
BJSummerfield
referenced
this pull request
Aug 26, 2025
fix(nix): Update flake.nix to configure Shell Plugins as functions vs. aliases
mrjones2014
approved these changes
Aug 26, 2025
Contributor
Author
|
Fixed merge conflicts |
BJSummerfield
force-pushed
the
bjs/fish-plugins
branch
from
7881104 to
591fe61
Compare
set programs fish at top level merge
BJSummerfield
force-pushed
the
bjs/fish-plugins
branch
from
591fe61 to
fc45441
Compare
mrjones2014
approved these changes
Aug 27, 2025
Member
mrjones2014
left a comment
mrjones2014
left a comment
There was a problem hiding this comment.
This looks great, thank you for your contribution!
Marton6
approved these changes
Aug 27, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Moved Fish to programs.fish -> Nixos would not compile as user.fish does not exist
added arguments to the new functions. Shell-plugin args were not passed to OP. I only tested fish, however the issue was present in bash and zsh.
Type of change
Related Issue(s)
How To Test
Code compiles now when using fish shell. Arguments are now passed to plugins through
opChangelog