refactor(flake): replace flake-utils with nix-systems#543
Merged
mrjones2014 merged 1 commit into1Password:mainfrom Aug 28, 2025
Merged
Conversation
Contributor
Author
|
CI is just failing on the old nixpkgs pin, not from this change. |
Member
|
Hi, thanks for your contribution! If you rebase on main your CI should pass, some long-needed maintenance surrounding the nix stuff has finally merged. |
Member
|
I'm happy to approve once that's done, this change looks good. |
luisnquin
force-pushed
the
refactor/replace-flake-utils-with-systems
branch
from
b1814e0 to
6e92afd
Compare
Contributor
Author
|
This looks ready. :) |
mrjones2014
approved these changes
Aug 28, 2025
Member
mrjones2014
left a comment
mrjones2014
left a comment
There was a problem hiding this comment.
Looks great and cuts down a bit of bloat in the dep tree! Thanks!
Member
|
Maybe @volodymyrZotov can provide a second approval? |
volodymyrZotov
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This change removes the dependency on
flake-utilsand replaces it withnix-systems.It introduces a
forAllSystemshelper based onnixpkgs.lib.genAttrsto generate development shells for all supported systems.The overall structure of the flake remains the same, but the dependency graph is simplified and more explicit.
Type of change
Related Issue(s)
How To Test
nix developon any supported system.go,gopls).nixosModulesandhmModulescan still be imported as before.Changelog
Replaced
flake-utilswithnix-systemsand refactored flake outputs to generate development shells for all supported systems.