Conversation
|
If you're new to commit signing, there are different ways to set it up: Sign commits with
|
e57cb7f to
52c721f
Compare
|
Thanks for the review Andy, will refactor the code |
7a710d1 to
0bb9f60
Compare
bd01b8b to
3fa8e90
Compare
77b11a9 to
c2e521c
Compare
|
I've updated the PR to focus solely on the config class changes as requested. Here are the key updates:
Please review these changes and let me know if any adjustments are needed. |
|
Hi @AndyTitu Any updates on this? Thanks |
|
Hi @AndyTitu |
|
@mattjacksoncello apologies for missing notifications on this. I'm on it now. |
AndyTitu
left a comment
There was a problem hiding this comment.
Code looks good to me apart from some small suggestions, thank you for the contribution! ❤️
LGTM Co-authored-by: Andi Titu <45081667+AndyTitu@users.noreply.github.com>
LGTM Co-authored-by: Andi Titu <45081667+AndyTitu@users.noreply.github.com>
|
@mattjacksoncello some tests are failing for the last changes. |
|
Hi Andy, |
|
@AndyTitu Could you have another look at this please |
|
@AndyTitu Can you review this please |
|
Hi @AndyTitu |
This PR is to implement a config class to allow more control over httpx for things like certificate verification.
I have also merged in the changes from #92
Note: I have used Claude to help with the changes. I have reviewed everything but I am not the strongest coder so there may be mistakes that I have missed