Skip to content

feat: Variable aggregation supports aggregating data into dictionary types.#4907

Merged
zhanweizhang7 merged 10 commits into1Panel-dev:v2from
wangliang181230:variable_aggregation_support_dict
Mar 24, 2026
Merged

feat: Variable aggregation supports aggregating data into dictionary types.#4907
zhanweizhang7 merged 10 commits into1Panel-dev:v2from
wangliang181230:variable_aggregation_support_dict

Conversation

@wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Mar 19, 2026

What this PR does / why we need it?

feat: Variable aggregation supports aggregating data into dictionary types.
新特性:变量聚合 支持聚合为字典类型的数据。

兼容性说明
数据值有所变更,但做过向下兼容处理,如果担心版本回退问题,我可以将数据值 variable_to_array 变更回 variable_to_json

fixes #4904

Summary of your change

  1. 界面变更:
    宽度变宽了,由默认的 340px 加大为 450px
图片
  1. 执行效果:
图片
  1. 其他类型保持不变:
图片 图片

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 19, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 19, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wangliang181230 wangliang181230 marked this pull request as ready for review March 19, 2026 06:38
@wangliang181230 wangliang181230 marked this pull request as draft March 19, 2026 06:38
@wangliang181230 wangliang181230 changed the title feat: Variable aggregation supports outputting dictionary types. feat: Variable aggregation supports aggregating data into dictionary types. Mar 19, 2026
@wangliang181230 wangliang181230 marked this pull request as ready for review March 19, 2026 06:55

def execute(self, input_variable, variable_list, **kwargs) -> NodeResult:
if type(input_variable).__name__ == "str":
if isinstance(input_variable, str):
Copy link
Contributor Author

@wangliang181230 wangliang181230 Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前提交的代码,顺便优化一下语法

@zhanweizhang7
Copy link
Contributor

Hi, please resolve the rebase conflict before we can continue the review. Also, could you squash the commits to clean up the history a bit? Thanks!

@wangliang181230
Copy link
Contributor Author

wangliang181230 commented Mar 24, 2026

Hi, please resolve the rebase conflict before we can continue the review. Also, could you squash the commits to clean up the history a bit? Thanks!

@zhanweizhang7
The rebase conflict has been resolved.
I don't know how to squash the commits, but I know that GitHub will automatically squash the commits when this PR is merged.

@zhanweizhang7 zhanweizhang7 merged commit 968259a into 1Panel-dev:v2 Mar 24, 2026
1 of 2 checks passed
@wangliang181230 wangliang181230 deleted the variable_aggregation_support_dict branch March 24, 2026 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] 变量聚合:希望添加一个选项,可聚合为 dict 类型数据(只是这 key 得添加一个输入框进行设置了。

2 participants