fix: route terminal websocket by operate node#12676
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a8b54c2b2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const endpoint = endpoint_.replace(/^\/+/, ''); | ||
| let conn = `${protocol}://${host}/${endpoint}?cols=${term.value.cols}&rows=${term.value.rows}&${args}&operateNode=${globalStore.currentNode}`; | ||
| if (args.indexOf('&operateNode=') !== -1) { | ||
| let node = args.indexOf('id=') !== -1 ? 'local' : globalStore.currentNode; |
There was a problem hiding this comment.
id query key
Using args.indexOf('id=') treats any parameter containing that substring as a host-terminal session and forces operateNode=local. This now misroutes non-host terminals such as container exec requests that use containerid=... (for example in frontend/src/views/website/runtime/components/terminal.vue and frontend/src/components/terminal/database.vue), so in multi-node deployments those WebSocket sessions are sent to the local node instead of the active node unless each caller manually adds operateNode. Please match the standalone id key (e.g., query parsing or a stricter pattern) rather than a raw substring.
Useful? React with 👍 / 👎.
2 participants
Refs #12677