Skip to content

fix: trim whitespace from command in ExecComposer method#12290

Merged
wanghe-fit2cloud merged 1 commit into1Panel-dev:dev-v2from
HynoR:fix/phpcompose
Mar 23, 2026
Merged

fix: trim whitespace from command in ExecComposer method#12290
wanghe-fit2cloud merged 1 commit into1Panel-dev:dev-v2from
HynoR:fix/phpcompose

Conversation

@HynoR
Copy link
Contributor

@HynoR HynoR commented Mar 23, 2026

What this PR does / why we need it?

fix #12285

问题在网站-PHP-Composer
image

Summary of your change

对最后composer拼接命令进行trimspace清理 避免多余空格

后期会给这个小模块前端和后端做对齐设计,比如自定义命令的判断和镜像源选择,目前发现迷惑性的东西挺多

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 23, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 23, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ssongliu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wanghe-fit2cloud wanghe-fit2cloud merged commit c10e574 into 1Panel-dev:dev-v2 Mar 23, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Default list of Composer commands has an extra space after each command

2 participants