fix: sidebar height inconsistency and favorites tooltip overlap#12280
Open
jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
Open
fix: sidebar height inconsistency and favorites tooltip overlap#12280jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
Conversation
Two UI fixes: 1. Sidebar items have different heights (1Panel-dev#12247) - .el-sub-menu had margin-top:7px on __title but no margin on wrapper - Now .el-sub-menu has margin:7px 0 matching .el-menu-item - __title margin reset to 0 to prevent double spacing 2. File favorites tooltip blocks adjacent items (1Panel-dev#11922) - Tooltip placement changed from "top" to "right" - Prevents tooltip from overlapping other favorites when scrolling Fixes 1Panel-dev#12247, 1Panel-dev#11922
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two UI fixes in one PR:
1. Sidebar items have different heights (#12247)
Dropdown menu items (el-sub-menu) were taller than regular items because
.el-sub-menu__titlehadmargin-top: 7pxwhile the outer.el-sub-menuhad no margin. Regular.el-menu-itemhadmargin: 7px 0.Fix: Move margin to
.el-sub-menuwrapper (margin: 7px 0), reset__titlemargin to 0.2. File favorites tooltip blocks other items (#11922)
The full-path tooltip on favorites used
placement="top", causing it to overlap adjacent items in the popover when scrolling past.Fix: Changed to
placement="right"so tooltips appear beside the item.Changed files
frontend/src/layout/components/Sidebar/index.scss- Normalize sub-menu marginsfrontend/src/views/host/file-management/index.vue- Tooltip placement top→right