Skip to content

fix: container backup should not fail entirely on mount copy errors #12276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakub961241 wants to merge 1 commit into
base: dev-v2
Choose a base branch
from
+10 −2
Open

fix: container backup should not fail entirely on mount copy errors #12276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions agent/app/service/backup_container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,11 +442,19 @@ func stepBackupContainerMounts(backupCtx *containerBackupContext) error {
}
if sourceInfo.IsDir() {
if err := backupCtx.fileOp.CopyDirWithNewName(item.Source, dataDir, "."); err != nil {
return err
mountMeta.Status = "failed"
mountMeta.Message = fmt.Sprintf("copy dir failed: %v", err)
backupCtx.meta.Mounts = append(backupCtx.meta.Mounts, mountMeta)
global.LOG.Errorf("container backup: skip mount %s, copy dir failed: %v", item.Source, err)
continue
}
} else {
if err := backupCtx.fileOp.CopyFile(item.Source, dataDir); err != nil {
return err
mountMeta.Status = "failed"
mountMeta.Message = fmt.Sprintf("copy file failed: %v", err)
backupCtx.meta.Mounts = append(backupCtx.meta.Mounts, mountMeta)
global.LOG.Errorf("container backup: skip mount %s, copy file failed: %v", item.Source, err)
continue
}
}

Expand Down