feat: allow stopping apps while in restarting state#12272
Open
jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
Open
feat: allow stopping apps while in restarting state#12272jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
Conversation
The Stop button was disabled for apps in 'ReStarting' status because the condition only allowed 'Running'. Apps stuck in a restart loop (e.g., due to DB connection issues) could not be stopped. Added 'ReStarting' to the allowed statuses for the Stop operation. Closes 1Panel-dev#12061
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #12061 - Apps stuck in a restart loop cannot be stopped.
Root Cause
The Stop button
disabledcondition only allowedstatus === 'Running':This means apps in
ReStartingstatus (e.g., DB connection failed, bad config) have Stop disabled, trapping users.Fix
Allow Stop for
ReStartingstatus too:Changed file
frontend/src/views/app-store/installed/index.vue(+1, -1)