fix: open container directory at WorkingDir instead of root#12265
Open
jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
Open
fix: open container directory at WorkingDir instead of root#12265jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
Conversation
…ev#12255) When clicking "Directory" on a container, the file browser always opened at `/` (root). Now it inspects the container first and opens at the container's configured WorkingDir (e.g., `/app`, `/var/www`). Falls back to `/` if WorkingDir is not set or inspect fails. Fixes 1Panel-dev#12255
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12255 - Container directory view shows root
/instead of the container's working directory.Changes
When clicking Directory on a container, the file browser now:
inspectAPI to get the container'sConfig.WorkingDir/app,/var/www)/if WorkingDir is not set or inspect failsChanged files
frontend/src/views/container/container/index.vue- Fetch WorkingDir via inspect before opening file browserfrontend/src/views/container/container/file-browser/index.vue- Accept optionalworkingDirparameter