Skip to content

Conversation

@dkotter
Copy link
Contributor

@dkotter dkotter commented Nov 15, 2024

Description of the Change

Version bump and prep for the 1.2.2 release

Closes #106

How to test the Change

Verify all file changes look accurate and tests pass

Changelog Entry

n/a

Credits

Props @dkotter

Checklist:

@dkotter dkotter added this to the 1.2.2 milestone Nov 15, 2024
@dkotter dkotter self-assigned this Nov 15, 2024
@dkotter dkotter requested a review from jeffpaul November 15, 2024 18:27
jeffpaul
jeffpaul previously approved these changes Nov 18, 2024
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for handling the release!

@jeffpaul
Copy link
Member

Seeing some test failures for wordfence and wpscan, worth checking those to see if there's something amiss that we need to account for here.

cc: @felipeelia @burhandodhy @iamdharmesh (as folks who helped on the primary PRs on the release)

@dkotter
Copy link
Contributor Author

dkotter commented Nov 18, 2024

Seeing some test failures for wordfence and wpscan, worth checking those to see if there's something amiss that we need to account for here.

I've fixed the Wordfence failures so we're good there. Looks like the output they return has changed slightly, which is what we look for in our tests, so had to update the test to account for that.

For WPScan, these are failing due to our API key not having access: ERROR_API_QUOTA_FULL: exceed daily rate limit hit. Not sure how to resolve this one without getting a paid API key

@dkotter dkotter requested a review from jeffpaul November 18, 2024 19:50
@jeffpaul
Copy link
Member

I've reached out to WPScan to see if we can get a slightly elevated account above the 25 API daily calls limit.

@dkotter
Copy link
Contributor Author

dkotter commented Nov 20, 2024

I've reached out to WPScan to see if we can get a slightly elevated account above the 25 API daily calls limit.

Do we want to proceed with the release here or wait for that API increase first?

@jeffpaul
Copy link
Member

I'm fine proceeding as I don't expect to hear back too quickly from WPScan on increased API limit.

@dkotter dkotter merged commit 7c9d43a into develop Nov 20, 2024
3 of 4 checks passed
@dkotter dkotter deleted the release/1.2.2 branch November 20, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release version 1.2.2

2 participants