Add helper text to Classification, Moderation & term cleanup screen#957
Add helper text to Classification, Moderation & term cleanup screen#957
Conversation
dkotter
left a comment
There was a problem hiding this comment.
Overall this looks good to me, nice work here. There are a bunch of eslint errors though that we'll want to get cleaned up before merging this in
|
Also, worth looking at #953 as it introduces some helper text as well and takes a slightly different approach (modal). We should standardize here so we don't have different approaches for the same thing. I'm okay with either, seems like maybe the modal approach gives us more flexibility though? |
|
@dkotter you're right! I think it gave us more flexibility so I think we should go with that solution instead. |
Yep, makes sense. I think the plan is to create a reusable component in that other PR so hopefully once that's done, it's a fairly easy implementation here |
|
@hugosolar if you've got continued time, perhaps helping get #953 to done would be great and then we can double back here to update accordingly? |
… moderation Providers in the future, we don't show that message when they are used. Update the message we show a bit
…ponents instead of our own custom HTML
…omponents instead of our own custom HTML
…we can reuse it. Use this for the label helper text for Watson. Ensure our helper text can be rendered as-is and not use dangerouslySetInnerHTML
…operly and we don't want to allow arbitrary HTML
✅ WordPress Plugin Check Report
📊 ReportAll checks passed! No errors or warnings found. 🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check |
… as this seems to perform better



Description of the Change
Adds helper texts to Watson settings as described in #919
Adds helper texts to Threshold % and change label.
Adds a new file to store helper texts
Closes #919 #918 #793
How to test the Change
npm run buildTooltip
Threshold

Language Processing > Term cleanup

Threshold
Language Processing > Moderation
Changelog Entry
Credits
Props @hugosolar
Checklist: