Feature: Move theme to 10up Framework #4
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR migrates the fueled-movies-complete theme to use the 10up Framework and fixes critical issues preventing the 10up-plugin mu-plugin from functioning after the theme switch. The migration introduces proper module-based architecture while resolving compatibility issues between the theme and mu-plugin.
Theme Migration to 10up Framework:
ThemeCore.phpclass implementing proper wp-framework ModuleInitialization systemAssets.phpto use wp-framework'sModuletrait andGetAssetInfofunctionalityBlocks.phpandTemplateTags.phpclasses following wp-framework patternscomposer.jsonto include10up/wp-frameworkdependencyFueledMoviesTheme\Mu-plugin Compatibility Fixes:
Moduletrait toAssets.phpclassModuletrait toAbstractPostMeta.phpclass (affects all PostMeta classes)Build System Configuration Fixes:
fueled-movies-completeinstead of10up-theme)Verification steps:
tenup_movie_mpa_ratingconfirmed working)TenupMovieMPARating)Benefits:
Alternative considered:
Closes #
How to test the Change
TenupMovieMPARating is not definederrorsnpm run buildto ensure build system works with new theme referencesnpm run watch:theme,npm run watch:plugin) work correctlyChangelog Entry
Credits
Props @colinswinney
Checklist: