This repository was archived by the owner on Jan 6, 2023. It is now read-only.
Adds support for manual key entry (of RFC 3548 base32 key strings)#13
Open
defkev wants to merge 1 commit into
Open
Adds support for manual key entry (of RFC 3548 base32 key strings)#13defkev wants to merge 1 commit into
defkev wants to merge 1 commit into
Conversation
Owner
|
Hi @defkev! I had something simular in mind for manually entering a screct . I will have a look at your commit next time when I touch the code! |
|
Hello. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Literally closes #7
Replaces the FAB with Clans/FloatingActionButton, providing a contextual menu to support adding a account by different means (either via QR or Private key) without sacrificing the sleek design.
It currently does some kind of form validation will adding a new account, by verifying wherever the user provided a private key or not, will validating the key itself isn't really possible.
Includes some basic code to select between TOTP/HOTP keys, its all commented until #10 gets implemented.