refactor(compose): update compose and start script#2159
Open
Mirko-von-Leipzig wants to merge 9 commits into
Open
refactor(compose): update compose and start script#2159Mirko-von-Leipzig wants to merge 9 commits into
Mirko-von-Leipzig wants to merge 9 commits into
Conversation
kkovaacs
reviewed
May 29, 2026
Contributor
kkovaacs
left a comment
There was a problem hiding this comment.
I like the idea of removing --enable-otel and relying on the environment variables instead.
However, there's not quite right with ntx-builder bootstrap in compose & the run script.
| echo "Bootstrapping network transaction builder..." | ||
| miden-ntx-builder bootstrap \ | ||
| --data-directory /data/ntx-builder \ | ||
| --genesis-block /data/genesis/genesis.dat |
Contributor
There was a problem hiding this comment.
This is not working for me:
Bootstrapping network transaction builder...
error: unexpected argument '--genesis-block' found
Usage: miden-ntx-builder bootstrap --data-directory <DIR> --rpc.url <URL>
For more information, try '--help'.
Shutting down...
Collaborator
Author
Collaborator
Author
There was a problem hiding this comment.
Or put differently; the order of my PRs are.. a bit out-of-order because I didn't want to rebase too many at once.
|
|
||
| "$NTX_BUILDER_BINARY" bootstrap \ | ||
| --data-directory "$NTX_BUILDER_DIR" \ | ||
| --genesis-block "$VALIDATOR_DIR/genesis.dat" |
Contributor
There was a problem hiding this comment.
This fails with the following error for me:
error: unexpected argument '--genesis-block' found
Usage: miden-ntx-builder bootstrap --data-directory <DIR> --rpc.url <URL>
For more information, try '--help'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does three deployment related things:
docker composefor the new sequencer/full node split.run-node.sh.Updates (1 & 2)
These still used the old
rpc,block-producer,storesplits.I also changed the bootstrap behavior from
profile genesisto using a sentinel file. This means on startup the bootstrap of each component check the sentinel file, if it exists they do nothing and the network launches. The main benefit here is that we no longer need a separate genesis/bootstrap invocation, simplifying things.The downside is that if we want to manually bootstrap/configure things then we will need to replicate this. Or we can add a flag that disables this behavior. Either way I think this is the exception, so simplifying the default "bootstrap and run" behavior made sense to me.
There are other minor differences & clean up that I did. So please do double-check this properly; its not a rubber stamp PR :)
Also note that the ntx bootstrap is left TODO as it requires #2158.
OTel changes
The executables now set certain OTel attributes on startup by default, and these can be overridden via the OTel env vars. More concretely:
Maybe we should use
miden.node.kindinstead ofrole?Further, I've removed the
--enable-otelCLI flag, and instead the behavior is inferred by checking the relevant OTel env vars for the URL to send to. This changes from the current behavior where by default OTel will export tolocalhost:<some-port>. In practice this meant doing--enable-otel trueand not setting the url env var resulted in error logs in stdout whenever the otel sdk attempted to upload the traces.Instead we now activate only if the url env vars are specified. However, maybe this is a poor idea and instead we should change the
--enable-otelinto--otel.export.trace.url, with the appropriate OTel env var? lmwyt..