refactor: yank store's RPC gRPC service#2147
Merged
Merged
Conversation
Mirko-von-Leipzig
added
store
kkovaacs
reviewed
May 27, 2026
| } | ||
| } | ||
|
|
||
| fn transaction_record_to_proto(record: TransactionRecord) -> proto::rpc::TransactionRecord { |
Contributor
There was a problem hiding this comment.
Why are these not From<> implementations anymore?
Collaborator
Author
There was a problem hiding this comment.
I figured we'd want to move these to the new gRPC implementation instead, so having them already owned here made sense to me 🤔
But I guess I didn't think overly hard here, was mostly just because the original From lived in the store where they are no longer available.
Collaborator
Author
There was a problem hiding this comment.
Oh actually its because the store no longer uses the proto crate, and therefore we have the orphan rule. Either the proto crate must use the store, or vice versa. Neither really makes sense, so the transform is done here.
sergerad
reviewed
May 28, 2026
Mirko-von-Leipzig
force-pushed
the
mirko/yank-store-bp
branch
from
a98665b to
1889a47
Compare
Mirko-von-Leipzig
force-pushed
the
mirko/yank-store-rpc
branch
from
ae32bb8 to
46b0731
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the final internal store gRPC service -- RPC.
It does this by in-lining the functions into
Stateand using that directly in the RPC layer.