feat(store): yank block producer service#2142
Open
Mirko-von-Leipzig wants to merge 3 commits into
Open
Conversation
Mirko-von-Leipzig
added
store
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the store's block-producer gRPC service. This leaves the store's RPC service as the only remaining item to yank.
The block-producer gets a store
Stateand directly accesses the previous gRPC methods instead. This also removes the store/block-producer desync opportunity.I also want to move the block proving to the block-producer, and have store only expose
Statewith no extra tasks attached. However, this will only really be possible after the last gRPC service is removed, so for now I've elected to minimize the diff instead of moving things across.Stacks on #2140.