refactor: wire mempool to RPC and store#2134
Closed
Mirko-von-Leipzig wants to merge 4 commits into
Closed
Conversation
Mirko-von-Leipzig
added
the
no changelog
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of #1961.
It removes the block producer's gRPC service, and the store's block producer gRPC service by giving the RPC component direct access to shared store
Stateand theSharedMempool. The RPC service can therefore directly implement the bits currently performed by the store and bp gRPC services.This PR does not use the state for read requests, only for the tx/batch submission paths. The former will be done in a separate PR.
The
apply_blockis also embedded into the block builder process chain itself, which removes the desync problem.The mempool subscription is also no longer required by the ntx builder so it also gets yanked.