refactor(response): merge text and text_with_charset into a single method

[0x676e67]

No description provided.

[cloudflare-workers-and-pages]

Deploying rnet with    Cloudflare Pages

Latest commit:	5310eb3
Status:	✅  Deploy successful!
Preview URL:	https://ae153c6f.rnet-7tt.pages.dev
Branch Preview URL:	https://ref.rnet-7tt.pages.dev

View logs

[gemini-code-assist]

Summary of Changes

Hello @0x676e67, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the API for retrieving text content from a response by consolidating two previously separate methods into one. This change improves consistency and reduces redundancy, allowing users to specify an encoding directly within the text method or rely on the default behavior when no encoding is provided.

Highlights

• API Consolidation: The text and text_with_charset methods on the Response object have been merged into a single text method. The new text method now accepts an optional encoding parameter.
• Type Hinting Update: The Python type hints in python/rnet/__init__.pyi have been updated to reflect the new text method signature, including the optional encoding parameter.
• Blocking Interface Alignment: The blocking interface in python/rnet/blocking.py has been updated to match the new text method signature, ensuring consistency across synchronous and asynchronous response handling.
• Rust Implementation Refactor: The underlying Rust implementation in src/client/resp/http.rs has been refactored to handle the optional encoding parameter within the text method, dynamically calling the appropriate internal text decoding logic.

Changelog

• python/rnet/init.pyi
  • Updated the text method signature to include an optional encoding parameter.
  • Removed the text_with_charset method.
• python/rnet/blocking.py
  • Updated the text method signature to include an optional encoding parameter.
  • Removed the text_with_charset method.
• src/client/resp/http.rs
  • Refactored the text method to accept an optional encoding parameter.
  • Implemented logic within text to conditionally use ResponseExt::text or ResponseExt::text_with_charset based on the presence of an encoding.
  • Removed the text_with_charset method.

Activity

• No activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a nice refactoring that merges the text and text_with_charset methods into a single text method with an optional encoding parameter. This simplifies the API. The changes in the Python type hints and stubs are correct.

In the Rust implementation, I've noticed some code duplication in both the asynchronous and blocking versions of the new text method. I've left a couple of suggestions to refactor the code to be more concise and maintainable. These changes should not affect the functionality.