Skip to content

🎨 Palette: Make OSINT modal trigger accessible for keyboard and screen reader users#79

Open
0m364 wants to merge 1 commit into
add-0m364-website-1232764033486168073from
palette-accessible-anchor-buttons-2923901992737797505
Open

🎨 Palette: Make OSINT modal trigger accessible for keyboard and screen reader users#79
0m364 wants to merge 1 commit into
add-0m364-website-1232764033486168073from
palette-accessible-anchor-buttons-2923901992737797505

Conversation

@0m364
Copy link
Copy Markdown
Owner

@0m364 0m364 commented May 10, 2026

💡 What:
Added role="button" and aria-haspopup="dialog" to the #sitrep-btn elements across concepts.html, contact.html, and products.html. Also updated modal.js to trigger the modal via the Spacebar key.

🎯 Why:
The OSINT trigger was using a native <a> tag with href="#". Native links do not respond to the Spacebar key like native <button>s do, leading to a broken expectation for keyboard users. Additionally, without the role="button", screen readers announce it as a "link" rather than an interactive control that opens a dialog.

📸 Before/After:
Before: Pressing Spacebar while focused on the OSINT button scrolled the page down.
After: Pressing Spacebar intercepts the scroll (e.preventDefault()) and opens the Situation Report modal exactly as the Enter key or a mouse click does.

♿ Accessibility:

  • Screen readers now correctly announce the control as a button that opens a dialog.
  • Keyboard-only users have full parity with mouse users, as both Enter and Spacebar keys function predictably for the control.

PR created automatically by Jules for task 2923901992737797505 started by @0m364

@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant