🎨 Palette: Make OSINT modal trigger accessible for keyboard and screen reader users#79
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Added
role="button"andaria-haspopup="dialog"to the#sitrep-btnelements acrossconcepts.html,contact.html, andproducts.html. Also updatedmodal.jsto trigger the modal via theSpacebarkey.🎯 Why:
The OSINT trigger was using a native
<a>tag withhref="#". Native links do not respond to theSpacebarkey like native<button>s do, leading to a broken expectation for keyboard users. Additionally, without therole="button", screen readers announce it as a "link" rather than an interactive control that opens a dialog.📸 Before/After:
Before: Pressing
Spacebarwhile focused on the OSINT button scrolled the page down.After: Pressing
Spacebarintercepts the scroll (e.preventDefault()) and opens the Situation Report modal exactly as theEnterkey or a mouse click does.♿ Accessibility:
EnterandSpacebarkeys function predictably for the control.PR created automatically by Jules for task 2923901992737797505 started by @0m364