Skip to content

Separate GitHub Pages technical root from landing#475

Merged
SoundBlaster merged 1 commit into
mainfrom
codex/github-pages-technical-root
May 28, 2026
Merged

Separate GitHub Pages technical root from landing#475
SoundBlaster merged 1 commit into
mainfrom
codex/github-pages-technical-root

Conversation

@SoundBlaster
Copy link
Copy Markdown
Member

Summary

  • What changed? Replaced the GitHub Pages landing deployment with a technical root deployment from docs/github-pages-root/.
  • Link related issue/task (if any): GitHub Pages root ownership bug described in chat.

Motivation

  • Why is this change needed? GitHub Pages root was owned by landing/, while the same landing is also published through the static-host workflow.
  • What problem, gap, or user need does it address? Prevents navigation loops where docs links route users back to the product landing instead of a technical entrypoint.

Goals

  • What should this PR achieve? Make GitHub Pages root explicitly technical and keep product landing on the custom/static host.
  • What is intentionally out of scope? No changes to SFTP artifact publishing, public bundle shape, or landing page content.

Changes

  • Renamed/repurposed the Pages workflow to deploy docs/github-pages-root/ instead of landing/.
  • Added a small technical root HTML page linking to artifact manifest, dashboard JSON, repository docs, and the custom landing page.
  • Documented the ownership boundary in docs/static_artifact_publish.md.

Validation

  • Tests added/updated for changed behavior
  • Local checks passed

Commands run:

git diff --check
python3 - <<'PY'
from pathlib import Path
import yaml
for path in sorted(Path('.github/workflows').glob('*.yml')):
    with path.open(encoding='utf-8') as fh:
        yaml.safe_load(fh)
print('workflow yaml parse: ok')
PY
rg -n "pages-landing|Deploy Landing to GitHub Pages|Upload landing artifact|path: landing" .github/workflows docs || true

Results:

  • git diff --check: passed.
  • Workflow YAML parse: passed.
  • No remaining GitHub Pages landing deployment references under .github/workflows or docs.

Risks / Notes

  • Backward compatibility impact: https://0al-spec.github.io/SpecGraph/ will stop showing the product landing and show the technical root after workflow deployment.
  • Migration/config changes required: none for static-host landing; it remains deployed by publish-static-artifacts.yml.
  • Known limitations: this does not generate DocC or full static docs; it establishes a technical entrypoint with stable links.

Checklist

  • PR title clearly describes the change
  • Scope is focused and minimal
  • Documentation updated (or N/A)
  • No secrets or sensitive data added

Copilot AI review requested due to automatic review settings May 28, 2026 20:23
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR repurposes the GitHub Pages deployment workflow so that the repository's github.io root serves a small technical entrypoint (docs/github-pages-root/) instead of the product landing page. The product landing remains owned by the custom/static host via publish-static-artifacts.yml, eliminating navigation loops where docs links route back to marketing.

Changes:

  • Renamed Pages workflow job and updated trigger paths + upload path to docs/github-pages-root/.
  • Added a new static HTML technical root page linking to artifact manifest, dashboard JSON, repo docs, and the product landing.
  • Documented the GitHub-Pages-vs-landing ownership boundary in docs/static_artifact_publish.md.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/pages-technical-root.yml Renames job/steps and switches deployment source from landing/ to docs/github-pages-root/.
docs/github-pages-root/index.html New technical entrypoint page with four cards pointing at artifact/runs/docs/landing surfaces.
docs/static_artifact_publish.md Adds explicit Pages ownership boundary paragraph.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SoundBlaster SoundBlaster merged commit 5cc94c1 into main May 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants