Skip to content

Conversation

@abdotop
Copy link
Member

@abdotop abdotop commented Jan 23, 2026

fix: timestamps and fetch params

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes two issues: incorrect timestamp units in the logging API and simplifies the fetch parameter signature in the api-client's signal wrapper.

Changes:

  • Fixed timestamp conversion in api/log.ts by converting from seconds to milliseconds
  • Simplified signal().fetch() signature in api-client/mod.ts to accept only headers instead of full Options object
  • Bumped package versions (api: 0.1.4→0.1.5, api-client: 0.1.6→0.1.7)

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
api/log.ts Converts timestamp from seconds to milliseconds for devtools API compatibility
api/deno.json Bumps version to 0.1.5 for the timestamp fix
api-client/mod.ts Refactors signal().fetch() to accept HeadersInit instead of Options, removing ability to override auto-managed signal and replacer
api-client/deno.json Bumps version to 0.1.7 for the API change

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

fetch: (
input?: HandlerIO<T, K>[0] | undefined,
options?: Options | undefined,
headers?: HeadersInit | undefined,
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking API change. The second parameter has been changed from options?: Options | undefined to headers?: HeadersInit | undefined. This means users can no longer pass signal or replacer options to signal().fetch(). While this appears intentional (since signal is auto-managed by the signal wrapper and replacer comes from signal(options)), this is a breaking change that should be:

  1. Documented in a CHANGELOG or migration guide
  2. Reflected in a major or minor version bump (the version was bumped from 0.1.6 to 0.1.7, which suggests a patch release)

Consider whether this breaking change warrants a minor version bump (0.2.0) instead of a patch bump (0.1.7), following semantic versioning conventions.

Suggested change
headers?: HeadersInit | undefined,
options?: Options | undefined,

Copilot uses AI. Check for mistakes.
@kigiri kigiri marked this pull request as ready for review January 23, 2026 17:16
@kigiri kigiri merged commit 78fd6e8 into master Jan 23, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix timestamp conversion in api/logs and fetch parameters in api-client

3 participants